bekh6ex / firefox-container-proxy

[Firefox extension] Assign a proxy to a Firefox container
https://addons.mozilla.org/en-US/firefox/addon/container-proxy/
BSD 2-Clause "Simplified" License
137 stars 14 forks source link

IP whitelist for specific proxies #21

Closed fishnux closed 3 years ago

fishnux commented 4 years ago

Hi,

I need to allow a specific IP address (localhost/127.0.0.1) to bypass a proxy, like what happens when you manually configure a proxy on Firefox. Would it be possible to add a whitelist on the extension's proxy configuration page?

Thanks!

bug-repport commented 4 years ago

Yes, me too! Trezor connection 127.0.0.1

2020-05-18_015553

bekh6ex commented 4 years ago

I'm wondering what would be the simplest useful solution to not overload the interface?

I would suggest to just add a one list for all the proxies as a general setting and fill it with safe defaults (e.g. 127.0.0.1, localhost, ::1).

Would it be sufficient? What do you think?

PS: Don't see a reason to set it up for each proxy. Why would one proxy have different setting than other? If anything, I think it might make sense to set it up per container, but then the interface would need a redesign and I'm not sure how useful this feature would be.

fishnux commented 4 years ago

For me that would work, a whitelist as a general setting πŸ‘

bug-repport commented 4 years ago

127.0.0.1 that's enough for me!

bug-repport commented 4 years ago

how soon will you update the plugin?

bekh6ex commented 4 years ago

Sadly, cannot promise anything these days. Too many things on my plate.

If someone creates a pull request with the fix, I might be able to merge and release it rather quickly.

bug-repport commented 4 years ago

ΠšΡƒΠ΄Π° Ρ‚Π΅Π±Π΅ ΠΌΠΎΠΆΠ½ΠΎ Π·Π°Π΄ΠΎΠ½Π΅ΠΉΡ‚ΠΈΡ‚ΡŒ Π·Π° Ρ€Π΅Π°Π»ΠΈΠ·Π°Ρ†ΠΈΡŽ этой Ρ„ΡƒΠ½ΠΊΡ†ΠΈΠΈ?

bekh6ex commented 3 years ago

Finally, I've managed to fix this. There is no configuration needed. The extension replicates Firefox behaviour and will not proxy any request from any container directed to localhost, 127.0.0.1 or ::1.

Update to extension version 0.1.14