search

bekh6ex / firefox-container-proxy

[Firefox extension] Assign a proxy to a Firefox container
https://addons.mozilla.org/en-US/firefox/addon/container-proxy/
BSD 2-Clause "Simplified" License
137 stars 14 forks source link

Enable extensions settings sync #53

Open dvcrn opened 2 years ago

dvcrn commented 2 years ago

Love this extension! Thanks a lot for building this

I was wondering how trivial it would be to enable extension settings sync for this. I adjust my proxies here and there and making the changes on all devices constantly is a bit tiresome, especially since the multi account container stuff is already syncing nicely.

(I know multi account containers now support proxy settings, but it still feels a bit half baked...)

dvcrn commented 2 years ago

Looks like it would just be changing the calls to storage.local to storage.sync if the user wants the settings to be synced

https://github.com/bekh6ex/firefox-container-proxy/blob/d7ecb89d344b42f359e1f77dd3a5f1948f99e49c/src/store/Store.ts#L135

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync

EkriirkE commented 1 year ago

Could this become a preferences toggle? Won't that user modification get lost when the extension updates?