search

bekoenig / getdown

Download, Install, Update
Other
4 stars 2 forks source link

Prefer digest2.txt over digest.txt #16

Open bekoenig opened 1 week ago

bekoenig commented 1 week ago

Clients with a new getdown version don't need the digest.txt file, because trusting digest2.txt is safe. So it's unnecessary to download and validate both files.

bekoenig commented 1 week ago

I think this is already implemented but not working properly due to a copy-paste error in this change. Currently both files are downloaded, but only digest2.txt will be validated (check here where the current digest version is hard coded). Looping over all digest versions is only necessary for computation process in Digester and not for downloading in Application.

After adding some integration tests I will check this presumption.