search

bekriebel / fvtt-module-avclient-livekit

Other
23 stars 12 forks source link

Noise Reduction #21

Open brunocalado opened 2 years ago

brunocalado commented 2 years ago

Hi!

I don't know if this is possible. But, can you add a noise reduction filter?

Something like discord or skype.

bekriebel commented 2 years ago

This is something I've done some research into and may add in the future. Unfortunately, I tried contacting Krisp (the one used by Discord), but they don't work with projects of this size.

sebastianmarkow commented 1 year ago

BTW, I think noise reduction is not enabled by default.

See: https://github.com/bekriebel/fvtt-module-avclient-livekit/blob/288d4476b4b84f23e425d164e38664b22dc32925/src/LiveKitClient.ts#L476-L479

Same for echo cancellation:

https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#noiseSuppression https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#echoCancellation

bekriebel commented 1 year ago

BTW, I think noise reduction is not enabled by default.

See:

https://github.com/bekriebel/fvtt-module-avclient-livekit/blob/288d4476b4b84f23e425d164e38664b22dc32925/src/LiveKitClient.ts#L476-L479

Same for echo cancellation:

https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#noiseSuppression https://docs.livekit.io/client-sdk-js/interfaces/AudioCaptureOptions.html#echoCancellation

The client is using the default capture options and only adding additional specific requirements. noiseSuppression and echoCancellation are enabled by default and are only disabled in the module when Music Mode is enabled.

patrickporto commented 2 days ago

https://docs.livekit.io/recipes/enhanced-noise-cancellation/

bekriebel commented 2 days ago

https://docs.livekit.io/recipes/enhanced-noise-cancellation/

That requires the use of LiveKit's $500/mo cloud plan. I assume no one is using that for Foundry :-)