bel28kent / Mysterium

An encoding of Alexander Scriabin's solo piano music in kern
7 stars 1 forks source link

Add invisible barline for mid-measure key change to C/a #25

Open bel28kent opened 1 year ago

bel28kent commented 1 year ago
          Mid measure key signatures are implemented in commit https://github.com/rism-digital/verovio/commit/fdf041393f016d6d2430e3b20f0076df559ea041

Example:

**kern
*M4/4
*k[f#]
=1
1c
=2
2d
*k[b-]
2e
=
*-

Rendering:

Screenshot 2023-08-17 at 13 22 39
Click to view MEI conversion of above Humdrum data ```xml </titleStmt> <pubStmt /> </fileDesc> <encodingDesc> <appInfo> <application isodate="2023-08-17T13:23:10" version="3.17.0-dev-ffd96fd"> <name>Verovio</name> <p>Transcoded from Humdrum</p> </application> </appInfo> </encodingDesc> <workList> <work> <title /> </work> </workList> </meiHead> <music> <body> <mdiv xml:id="m9xt05d"> <score xml:id="s1ut797s"> <scoreDef xml:id="s1so24fo" midi.bpm="400.000000"> <staffGrp xml:id="s1oq43hn"> <staffDef xml:id="staffdef-L1F1" n="1" lines="5"> <clef xml:id="c1rb3gbm" shape="G" line="2" /> <keySig xml:id="keysig-L3F1" sig="1s" /> <meterSig xml:id="metersig-L2F1" count="4" unit="4" /> </staffDef> </staffGrp> </scoreDef> <section xml:id="section-L1F1"> <measure xml:id="measure-L1" n="1"> <staff xml:id="staff-L1F1" n="1"> <layer xml:id="layer-L1F1N1" n="1"> <note xml:id="note-L5F1" dur="1" oct="4" pname="c" accid.ges="n" /> </layer> </staff> </measure> <measure xml:id="measure-L6" n="2"> <staff xml:id="staff-L6F1N1" n="1"> <layer xml:id="layer-L6F1N1" n="1"> <note xml:id="note-L7F1" dur="2" oct="4" pname="d" accid.ges="n" /> <keySig xml:id="keysig-L8F1" type="mid-measure" sig="1f" /> <note xml:id="note-L9F1" dur="2" oct="4" pname="e" accid.ges="n" /> </layer> </staff> </measure> </section> </score> </mdiv> </body> </music> </mei> ``` </details> <hr /> <p>Note that when the mid-measure key signature changes to C major/A minor, the cancellation naturals are not shown yet:</p> <pre><code class="language-tsv">**kern *M4/4 *k[f#] =1 1c =2 2d *k[] 2e = *-</code></pre> <p>Rendering:</p> <img width="582" alt="Screenshot 2023-08-17 at 13 24 35" src="https://github.com/humdrum-tools/verovio-humdrum-viewer/assets/3487289/25657bf3-c845-4700-b748-2c7e73999ede"> <details> <summary> Click to view MEI conversion of above Humdrum data </summary> ```xml <?xml version="1.0" encoding="UTF-8"?> <?xml-model href="https://music-encoding.org/schema/dev/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?> <?xml-model href="https://music-encoding.org/schema/dev/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?> <mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="5.0.0-dev"> <meiHead> <fileDesc> <titleStmt> <title /> </titleStmt> <pubStmt /> </fileDesc> <encodingDesc> <appInfo> <application isodate="2023-08-17T13:25:15" version="3.17.0-dev-ffd96fd"> <name>Verovio</name> <p>Transcoded from Humdrum</p> </application> </appInfo> </encodingDesc> <workList> <work> <title /> </work> </workList> </meiHead> <music> <body> <mdiv xml:id="m1s4j3x3"> <score xml:id="s1c5xu57"> <scoreDef xml:id="srk0660" midi.bpm="400.000000"> <staffGrp xml:id="spxsrhh"> <staffDef xml:id="staffdef-L1F1" n="1" lines="5"> <clef xml:id="c1o64pwg" shape="G" line="2" /> <keySig xml:id="keysig-L3F1" sig="1s" /> <meterSig xml:id="metersig-L2F1" count="4" unit="4" /> </staffDef> </staffGrp> </scoreDef> <section xml:id="section-L1F1"> <measure xml:id="measure-L1" n="1"> <staff xml:id="staff-L1F1" n="1"> <layer xml:id="layer-L1F1N1" n="1"> <note xml:id="note-L5F1" dur="1" oct="4" pname="c" accid.ges="n" /> </layer> </staff> </measure> <measure xml:id="measure-L6" n="2"> <staff xml:id="staff-L6F1N1" n="1"> <layer xml:id="layer-L6F1N1" n="1"> <note xml:id="note-L7F1" dur="2" oct="4" pname="d" accid.ges="n" /> <keySig xml:id="keysig-L8F1" type="mid-measure" sig="0" cancelaccid="before" /> <note xml:id="note-L9F1" dur="2" oct="4" pname="e" accid.ges="n" /> </layer> </staff> </measure> </section> </score> </mdiv> </body> </music> </mei> ``` </details> <p>This is related to issue <a rel="noreferrer nofollow" target="_blank" href="https://github.com/rism-digital/verovio/issues/3497#issue-1853010843">https://github.com/rism-digital/verovio/issues/3497#issue-1853010843</a></p> <p>To make visible in the meantime, add an invisible barline as mentioned above.</p> <p><em>Originally posted by @craigsapp in <a rel="noreferrer nofollow" target="_blank" href="https://github.com/humdrum-tools/verovio-humdrum-viewer/issues/830#issuecomment-1682121650">https://github.com/humdrum-tools/verovio-humdrum-viewer/issues/830#issuecomment-1682121650</a></em></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/bel28kent"><img src="https://avatars.githubusercontent.com/u/81043032?v=4" />bel28kent</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Pieces to check-up on when issue is resolved:</p> <ul> <li>[ ] op07_no02</li> </ul> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>