bel28kent / Mysterium

An encoding of Alexander Scriabin's solo piano music in kern
7 stars 1 forks source link

Tab replaced with space in op 8/3 #38

Closed craigsapp closed 5 months ago

craigsapp commented 6 months ago

In scriabin-op08-n03.krn, there it a space instead of a tab:

Screenshot 2024-02-25 at 18 25 07

(The gray box highlights where the space should be converted into a tab).

bel28kent commented 6 months ago

I will resolve this in April/May, when I am planning on finishing the corpus, unless you need a change to the server copy before then.

craigsapp commented 6 months ago

No hurry.

bel28kent commented 5 months ago

The problem was that the awk script that I wrote some time back to find spacing errors didn't take record type into account (e.g., reference record, interpretation, etc.). So it couldn't handle the use case where you have spaces on an interpretation record because I ignored spaces in the tab-spaced columns due to the complexity of nested spaces in stops. I have written a more robust Perl program that handles this. I then wrapped that in another Perl program that filters out files that don't actually have spacing errors.

For the main branch, this resulted in the following files being found to have errors:

Screen Shot 2024-03-31 at 5 43 57 PM

For the editing branch, this resulted in the following files being found to have errors:

Screen Shot 2024-03-31 at 5 41 56 PM
bel28kent commented 5 months ago

On main, the sole error in scriabin-op08_no03.krn is spaces on an interpretation record:

Screen Shot 2024-03-31 at 5 51 40 PM
bel28kent commented 5 months ago

For the editing branch, the error in scriabin-op08_no03.krn is the same.

For scriabin-op07_no01.krn these two records have too many tabs:

Screen Shot 2024-03-31 at 5 58 38 PM
bel28kent commented 5 months ago

Error on main fixed in 5eac98e7b0b482a0d03afc5b3fab486dc65fe0fc

bel28kent commented 5 months ago

Errors on editing branch fixed in ce277d74185afe788b2a176850ef4d12755008d2