search

belangeo / pyo

Python DSP module
GNU Lesser General Public License v3.0
1.28k stars 130 forks source link

Missing a terminator after strncpy in function Server_jack_init, which may cause read-overflow #221

Closed awen-li closed 3 years ago

awen-li commented 3 years ago

Code snippet

Server_jack_init(Server *self)
{
    int i = 0;
    char client_name[32];  -----------> No initialization
    char name[16];
     .........
    strncpy(client_name, self->serverName, 31);  -------------> when length of self->serverName is 31,  client_name may has no terminator. It is a risk of read-overflow.
     .........
}

Description

Function: Server_jack_init File: ad_jack.c Call-path: boot (Python) -> Server_boot -> Server_jack_init WarningType: read-overflow. Our analysis tool reported a warning at the call-site of strncpy. As client_name is not initialized, it may has no terminator after strncpy hence to cases read-overflow. Also seen in Details

awen-li commented 3 years ago

Anyone can help confirm this issue? thanks.

belangeo commented 3 years ago

I'll take a look as soon as I get a chance. Thanks for reporting.

belangeo commented 3 years ago

Fixed. Turns out that the copy was completely useless!

awen-li commented 3 years ago

Fixed. Turns out that the copy was completely useless!

thanks