search

belangeo / pyo

Python DSP module
GNU Lesser General Public License v3.0
1.31k stars 131 forks source link

Win build improvements #245

Closed CristiFati closed 2 years ago

CristiFati commented 2 years ago

Hardcoding stuff (especially paths) is not scalable, and can trigger all kinds of issues, especially when operating in other environments (also, I consider it lame). Also keeping the .dlls here might trigger weird issues, as the code is linked against a set of .lib files (from a newer library version - depending on VCPkg) and using a different set of .dlls.

Noticed that (in a simple scenario) vorbisfile.dll is not loaded by the Python process, but left it in anyway.

Tests

Described in [SO]: Can't install pyo using pip (@CristiFati's answer).

belangeo commented 2 years ago

Looks good, thank you! Only the last commit will break on systems other than Windows, but good clean up overall! I'll try to test it in the upcoming days.

CristiFati commented 2 years ago

Yeah, sorry about the last one, it was not related to this PR. I didn't bother to build on Nix (or at least look below in the function for #ifdefs). :(