search

belaviyo / download-with

A set of extensions to ease the integration with an external download manager
https://add0n.com/download-with.html
97 stars 67 forks source link

Packagizer ignores package name setting #44

Open Salvora opened 3 years ago

Salvora commented 3 years ago

I use jdownloader 2.0 with firefox with the "Download with Jdownloader" addon. I have a longstanding custom rule defined in the packagizer, I have been using for a long time. The last time I downloaded something was like a month ago and there was no problem. Today, I tried to download again but I noticed that the packagizer rule for setting the package name is getting ignored. The rule sets the download destination correctly but not sets the package name. It sets the package name per individual file. But packagizer should gather those files from the same host under the same package name so it is easy to see them all together. I think some update broke this because I use the same host everytime with same file types. I noticed that whichever tab is focused on the firefox while I am sending the file to jdownloader sets the package name. I am not sure if this due to the addon or the jdownloader itself but it is highly likely that some update for the jdownloader broke the addon.

hunkyburrito commented 6 days ago

This is due to the extension hardcoding the packagename to be either the tab title or an empty string if it can't get that. I don't know of any way to fix that without editing it manually other than removing/commenting that line in the add-on code (which I can confirm works). Relevant line is in worker.js file, line 62 (body.append('package', tab.title || '');) if you want to edit it.