belaviyo / keepass-macpass-helper

A helper extension to use KeePass/MacPass/KeePassXC from Firefox, Opera, and Chrome browsers
https://webextension.org/listing/keepass-helper.html
Mozilla Public License 2.0
103 stars 27 forks source link

Microsoft Edge Support #23

Open shmuelie opened 6 years ago

shmuelie commented 6 years ago

Please add support for Microsoft Edge

belaviyo commented 6 years ago

Unfortunately, I don't have a dev account. If somebody would like to contribute and provide a dev account, I can work on the compatibility

Magneticdud commented 6 years ago

I have a dev account, but it's free, right? I did not pay any money to have it (but maybe I got it for free with dreamspark?)

In order to publish an extension for edge first, you need to be whitelisted manually by Microsoft (they don't want potential malware) at this link: https://developer.microsoft.com/en-us/microsoft-edge/extensions/requests/

edit: or manual install without passing from the store like this other extension is doing https://github.com/MrTambourineSLO/SasoHighlightedSearch-Edge

belaviyo commented 6 years ago

@Magneticdud please try to submit the whitelisting request. If it gets accepted we will publish it!

Magneticdud commented 6 years ago

immagine immagine

ok! Let's see what they will say

belaviyo commented 6 years ago

perfect!

Magneticdud commented 6 years ago

I already got an answer: immagine

Reply:

immagine

Magneticdud commented 6 years ago

Got an answer. Big problem, in order to give a good experience to "windows s" users (who can only install apps from windows store), an app that has the keepasshttp server component must be already present in the store. (but then it can connect to whatever)

Plan A: I ask if one of the two/three UWP apps already on the store can include the keepasshttp server (unlikely)

Plan B: I fork KeePassXC and publish it on the microsoft store (now they accept also regular apps). I don't like this approach as I don't have the time to maintain the fork, and users will get outdated stuff.

Plan C: Dominik Reichl is publishing the original KeePass on the store - we could ask to include keepasshttp.plgx in the package

belaviyo commented 6 years ago

I fork KeePassXC and publish it on the microsoft store

They plan to discontinue the keepasshttp implementation due to the security issues.

Dominik Reichl is publishing the original KeePass on the store

We can have a simple native wrapper to get credentials from the KeePass application directly. Unfortunately, there is no way to get them without having a plugin as far as I know. I would say we need to communicate to get this feature implemented. This way we can support both keepasshttp and the native communication.

Another option is to implement database reading directly which is doable but since we do not have access to the local hard disk, we can only cache the database so there would limit the usage. I am more into the native communication option to keep the extension simple and secure.

belaviyo commented 6 years ago

I got this reply from Dominik regarding the native support.


Hi Joe,

I'm not planning to add such an interface in the near future, sorry.

Magneticdud commented 4 years ago

Now that Edge is based on Chrome, they accept any extension => https://docs.microsoft.com/en-us/microsoft-edge/extensions-chromium/publish/publish-extension

gvlx commented 4 years ago

It is working: Version 83.0.478.54 (Official build) (64-bit)

gamedevsam commented 4 years ago

I recommend closing this issue.

m-alice commented 4 years ago

https://microsoftedge.microsoft.com/addons/detail/keepasshelper-password-ma/bfmglfdehkodoiinbclgoppembjfgjkj Very thanks!

error401de commented 4 years ago

Basically it works in Edge, only the "Keyboard Shortcut Setting" is missing. If I click the button I'm only forwarded to edge://extensions/. In there I can't see an option to set the shortcut.