search

belaviyo / save-images

Save loaded images in nested iframe pages
https://webextension.org/listing/save-images.html
254 stars 61 forks source link

Save Filename template keywords or name no longer gets used #90

Closed FaceCrap closed 6 months ago

FaceCrap commented 8 months ago

I suspect a recent windows update (or chrome) update changed something because in both Edge and OperaGX, the template keywords or even a specified name no longer gets used to save the downloaded images zip file. It now always ends up getting saved with a random long hex name like for example "2eea4572-0c31-43fb-884b-c8887888fb70.zip" I also tried Google Chrome, but in that browser I just get a blank, empty popup...

FaceCrap commented 6 months ago

Solved...

I have/had more than one download extension loaded... turns out they can bite each other.

As per the chrome.downloads API, if even one extension assigns a custom eventhandler to the chrome.downloads.onDeterminingFilename listener, it will prevent every other download extension from specifying a custom filename if it bypasses the Save As dialog.

It gets even more hairy...

in the documention for onDeterminingFilename itself... "A custom handler must call suggest to construct the target filename" but... If more than one extension overrides the filename, then the last extension installed whose listener passes a suggestion object to suggest wins.

and another beauty... In order to avoid confusion regarding which extension will win, users should not install extensions that may conflict. But how dafuq is a typical Joe Enduser to know which extensions may conflict???