belaviyo / save-images

Save loaded images in nested iframe pages
https://webextension.org/listing/save-images.html
254 stars 61 forks source link

Dialog stays blank on any comic page on https://allporncomic.com #93

Open FaceCrap opened 5 months ago

FaceCrap commented 5 months ago

Like the subject says, I'm using the Edge browser. On every comic page I open on https://allporncomic.com, the dialog stays blank after clicking the extension button. I've only seen this happen on this site, on every other site in other tabs it works perfectly fine.

image

Patty-OFurniture commented 5 months ago

My opinion - I would caution anyone against visiting this site, especially without some ad blocker and/or noscript. VirusTotal and Google Safe Browsing report it as safe, but I'm still suspicious, and detailed ownership is protected by a privacy co. And the content may not be legal everywhere based on the screenshot.

@FaceCrap You might be better off just saving the web page. The images and all other content will be saved locally. CTRL-S or Right-click -> Save as. The workflow isn't as simple, but you will have what you want to have.

I'll just suggest a few things in general if this happens on another website. The dialog not showing tells me something is going wrong before this add-on can do much, so it can't fix much. I would guess there is too much JavaScript activity in the background, conflicting with or interfering with the dialog creation. The site could even be trying to protect itself from this type of add-on. You could try getting more information via Developer Tools (F12 or 3 dots -> More tools -> Developer tools) and looking at the Console tab.

You can also try a different web browser. Edge is based on Chromium, so it should work a lot like Chrome, but there are differences. I would suggest Chrome first. Next suggestion would be Firefox or Opera.

FaceCrap commented 5 months ago

I would caution anyone against visiting this site, especially without some ad blocker and/or noscript. VirusTotal and Google Safe Browsing report it as safe,

I use uBlock, anything 3rd-party and ads get blocked, using noscript would also prevent the extension from working. So that limits it to just blocking 3rd-party scripts.

You might be better off just saving the web page. The images and all other content will be saved locally.

Apart from it totally defeating the purpose of why this extension was written in the first place, you'd not believe how much junk I'd have to wade through, sifting out just those images I wanted to save. Besides, the images are lazy-loaded when scrolling down the page, so Ctrl-S won't download them all in one go... need several attempts for that.

The dialog not showing tells me something is going wrong before this add-on can do much, so it can't fix much. I would guess there is too much JavaScript activity in the background, conflicting with or interfering with the dialog creation.

This used to work before, and I don't see any changes in the page that might indicate they changed something to interfere. Plus, I'm not that clueless to not wait until the page is done loading and the tab indicates it's done. Also, background activity would show up in the Browser's own task manager.

The site could even be trying to protect itself from this type of add-on.

This might very well be the case, if it weren't something that totally wouldn't protect them from anything, after all, the images get downloaded one way or another... so it's not like you're wasting their bandwidth or putting an unnecessary load on the server.

You could try getting more information via Developer Tools (F12 or 3 dots -> More tools -> Developer tools) and looking at the Console tab.

That's exactly what I tried, for what good it will do, since I'm no expert, if I were I'd not posted the problem but made a PR with the solution... All I could find out is that the code seems to get loaded. At least I see the html for both the analyzer and the gallery appear in the elements tab, but can't figure why it's not showing, CSS doesn't gave a clue either.

You can also try a different web browser.

Opera does the same. Don't have Chrome, not intending to start doing so just for this test.

Patty-OFurniture commented 5 months ago

I will try to help, and again I cannot speak on behalf of the author, but I am absolutely not going to that site to debug it myself. Anyone would need, again for websites that don't work in general, basic troubleshooting information:

Without that info, the best and maybe only solution would be a "no lazy load" extension and file de-duplicator along with File/Save. De-dupe will leave the garbage in one folder so you don't have to wade through it again. I happen to have both in my repos, and that is what I use as my workflow generally. Of course, I likely have different goals and it doesn't sound like that would be acceptable. What it is, is available.

Because supporting every website is impossible. I could come up with a ridiculous example of a domain that no one in their right mind would admit to visiting, even if only implicitly by adding a PR to support / work around it. I do hope you understand.