belbio / bel_resources

BEL resources and tools for namespaces, annotations, orthologs, taxonomy, etc and tool
https://bel-resources.rtfd.io
Apache License 2.0
2 stars 0 forks source link

Add pmod equivalents to GO #22

Open wshayes opened 6 years ago

wshayes commented 6 years ago

From Charlie Hoyt:

I would suggest grounding all of these in either GO or SBO terms. I've already assembled the mappings in PyBEL:

https://github.com/pybel/pybel/blob/4ba6c4ed33bf724297fadd6e5e73c6b02099982d/src/pybel/parser/language.py#L248-L405

https://github.com/pybel/pybel/blob/4ba6c4ed33bf724297fadd6e5e73c6b02099982d/src/pybel/parser/language.py#L429-L442

ncatlett commented 6 years ago

It looks like these mappings for protein modifications are GO biological process terms - refering to the process of ubiquitination, hydroxylation, etc. rather than the modification itself. I suggest mapping instead to something like PSI-MOD (I did this, will try to track down the file)

cthoyt commented 6 years ago

@ncatlett counterpoint - if we were to make this distinction, we might have to write statements like "the process of ubiquitination causes an increase in the abundance of protein X with ubiquitin modification." I think in the world of knowledge assembly in BEL, these can used reasonably interchangeably.

After a short look, it seems like PSI-MOD is not as robust as GO. When it comes to these, I would personally always defer to the best maintained resources.