search

belerico / py_asciimath

A simple converter from ASCIIMath to LaTeX or MathML and from MathML to LaTeX
MIT License
38 stars 10 forks source link

logging.basicConfig might be in the wrong place #7

Closed frozflame closed 1 year ago

frozflame commented 3 years ago

I think it's not proper to config log level DEBUG inside many inner modules: 

logging.basicConfig(format="%(levelname)s:%(message)s", level=logging.DEBUG)

It makes this package unusable in interactive mode, unless the user understand how to deal with the logging stuff.

My suggestion is to put the logging.basicConfig only inside your entry point scripts / functions.

belerico commented 3 years ago

Hi, thanks for the suggestion :) If you want, you can also open a pull request ;)

belerico commented 3 years ago

Solved in 3d789f54a7696e747b09750dbd47e8af88e69e55