belgif / rest-guide

REST Guidelines of Belgian government institutions
https://www.belgif.be/specification/rest/api-guide/
Apache License 2.0
24 stars 4 forks source link

Update GitHub actions #170

Closed pvdbosch closed 1 month ago

pvdbosch commented 7 months ago

In builds of rest-guide and the openapi-* projects, we have some deprecation warnings in the builds about

For rest-guide, I already updated two offending github actions to latest version (+ JDK 17):

    - uses: actions/checkout@v4
    - name: Set up Adopt OpenJDK 17
      uses: actions/setup-java@v4
      with:
        distribution: adopt
        java-version: '17'

The release actions (actions/create-release@v1 and actions/upload-release-asset@v1) have become unmaintained however, and should be replaced by alternatives.

Is there someone who wants to work on this?

jpraet commented 6 months ago

GitHub CLI comes preinstalled on all GitHub hosted runners. If that meets the requirements, that seems more future proof to me than searching for an alternative action that risks becoming unmaintained: https://cli.github.com/manual/gh_release_create

jpraet commented 4 months ago

Once the updated gh-actions release workflow of https://github.com/belgif/openapi-location/pull/9 has been validated, I will create PRs to apply the same changes to the other repos.

jpraet commented 4 months ago

We also have these workflow templates that I forgot about. It is also possible to define reusable workflows.

pvdbosch commented 1 month ago

@jpraet , I released belgif-openapi-location 1.2.0 with the new Github Actions without a problem. The artifacts still have to be indexed by Maven Central, but I verified staging.

jpraet commented 1 month ago

Do I copy the configuration over to the other belgif/openapi-* repos, or should I try a reusable workflow?

pvdbosch commented 1 month ago

Reusable workflow looks a bit easier to maintain in the long run; if it isn't too much work

jpraet commented 1 month ago

Reusable workflows created in this new workflows repo, and activated for all belgif/openapi-* repos.