belgif / thematic

ICEG: Thematic Working Groups
11 stars 5 forks source link

Building object type #100

Closed bfrichet3 closed 1 year ago

bfrichet3 commented 1 year ago

Dear

I have some concerns regarding the Building object type as it specified in the current model.

1) concerning the name property, the content of the "Usage" column is irrelevant. As you may read it, one should instantiate the LangString object type in that property, and certainly not a string. In your instance you mention some strings ('Big Ben', ...).

All these must be removed and if you want to, you may specify that kind of examples in the LangString object type in the relevant property (i.e. 'string' property).

2) concerning the geometry property, the content range should be clarified. As one reads your vocab, he will understand that he can instantiate nothing but the BuildingGeometry (which does not seem to be an abstract object type). One won't be allowed to use an object of BuildingGeometry2D or BuildingGeometry3DLoD2 (as they are not concrete class derived from an abstract class).

It should be specified somewhere that BuildingGeometry is an abstract (if it's such a class) or it should be specified that all the classes with inheritance relationship with BuildingGeometry are substitutable with BuildingGeometry.

3) concerning consistsOf and numberOfDwelling, I would say that their definitions are quite unusual in the vocabularia as they begin with an article ('the'). I would remove these articles.

4) concerning currentUse, I would say that the content of "Usage" column begins with 'Note'. I would remove that word.

yarondassonneville commented 1 year ago

Thank you for the comment. We will adapt the model accordingly as these comments are helpful.

bfrichet3 commented 1 year ago

Ok perfect. I am waiting for your updated model's specifications

bahimc commented 1 year ago

Hello @bfrichet3, coming back to your second comment: BuildingGeometry is not an abstract class but a datatype. BuildingGeometry2D or BuildingGeometry3DLoD are sub-datatypes and can be substituted.

bfrichet3 commented 1 year ago

you are totally all right, I noticed it later