belgif / thematic

ICEG: Thematic Working Groups
11 stars 5 forks source link

Issue with Measure #115

Closed GeertThijs closed 1 year ago

GeertThijs commented 1 year ago

There are some issues with Measure:

GeertThijs commented 1 year ago

In a data-example the solution with ISO19103:Length would look like this: { "@context": { "@vocab": "https://example.com/ns/", "iso": "http://def.isotc211.org/iso19103/2015/MeasureTypes#" }, "length": { "@type": "iso:Length", "iso:Measure.value": 90, "iso:Length.uom": { "@type": "iso:UomLength", "iso:UnitOfMeasure.uomIdentifier": "m" } } } The current solution looks like this: { "@context": { "@vocab": "https://example.com/ns/", "inspire-base": "http://inspire.ec.europa.eu/ont/base#", "iceg-building": "http://vocab.belgif.be/ns/building", "qudt": "https://qudt.org/schema/qudt/", "skos": "http://www.w3.org/2004/02/skos/core#" }, "length": { "@type": "inspire-base:Measure", "qudt.value": 90, "iceg-building:uom": { "@type": "skos:Concept", "@id": "https://example.com/concept/unittype" } } }

GeertThijs commented 1 year ago

Actually OSLO analysed several possibilites to model quantitative values like Length. We advise solution no 5 or 6. Solution 5 is based on a value and unit structure with a unit as a string according to ucum (= ISO2955 symbols) and 6 is also a value and unit structure with a skos:Concept for the unit based on qudt. I would advise to go with the ISO19103 solution which is very similar to solution 5 or with solution 5 or with solution 6. INSPIRE-base:Measure is defined according to solution 2 (value and unit in the same string), but has been implemented by ICEG-building as solution 6 but mapped to qudt for the value and a ICEG uri for the unit.

bahimc commented 1 year ago

The proposed ISO solution for the issue has a problem with how units of measure are classified. They are currently listed as strings, which allows for any value to be entered. Additionally, the ISO Length class is described as abstract, meaning that a specific implementation is needed. Using QUDT, which is an industrial specification, is not in line with INSPIRE standards, as INSPIRE uses GML measures and OGC standards. The use of QUDT also does not align with the European classification of units of measure, which can be found at https://op.europa.eu/en/web/eu-vocabularies/concept-scheme/-/resource?uri=http://publications.europa.eu/resource/authority/measurement-unit. Therefore, the solution proposed to use the base:Measure class with the properties qudt:value and iceg-building:uom is a compromise, as the original definition of base:Measure is focused on text representation rather than structured values.

GeertThijs commented 1 year ago

Here more verbose the reasons why NOT to use inspire-base:Measure:

bahimc commented 1 year ago

The conclusion of this comment is that the use of Inspire-base:Measure is not recommended in favor of ISO19103:Measure, as the latter is more compliant with the ICEG implementation and is the datatype of many attributes in the INSPIRE model. Additionally, it is recommended to use ISO19103:Measure.value instead of qudt:value, and to allow for different solutions for unit representation, such as using qudt, URI or Literal, as there are various options available, and the use of a specific one will depend on the specific use case. We agree with the first two points mentioned however, ISO19103:Measure.value is an object property and therefore qudt:value is better as being a generic property. Our stance is that ICEG should what is there at European level first, and reuse controlled vocabularies from the Publications Office when possible. Our proposed resolution would be to reuse QUDT:value or create a new property, which would allow to have control over the definiton.

GeertThijs commented 1 year ago
bahimc commented 1 year ago

We agree that Qudt:value is more generic than iso:Measure.value and that it could be used in the context of a Measure or QuantitativeValue. Also, QUDT:Unit is not a subclass of skos:Concept. So, we would therefore opt for defining our own attribute (iceg:unit) while using the European NAL database of measurement units, as it provides a centralized reference of measurement units and their properties. Do you agree with the suggestion?

GeertThijs commented 1 year ago