belgif / thematic

ICEG: Thematic Working Groups
11 stars 5 forks source link

Feedback on Location Entity Attributes #133

Open bahimc opened 1 year ago

bahimc commented 1 year ago

We would like to request feedback from the community on the Location entity attributes in the ICEG Data Model. Specifically, we would like to know if the following attributes for this entity are sufficient to cater for various use cases or if there are any attributes that are missing:

Attributes:

Attributes originating from BeST Address:

In addition, we would like to know if the community would prefer any of these attributes to be optional or mandatory and what the cardinalities should be. We would also like to know if the community would be able to provide all the mandatory information, and with data minimization in mind, or if some of the entities and/or attributes should be stripped off.

Please share your feedback and suggestions so that we can improve the ICEG Data Model. Thank you in advance for your valuable input!

VPiersonSWDE commented 1 year ago

location.addressPosition: Can you give more information on this field?

VPiersonSWDE commented 1 year ago

location.adressRepresentationType: What is the purpose of this field? What will be its use? How are we supposed to fill it in? Subjective by field people or objective via GIS analysis? (And if we put the field names in English, shouldn't we put addressRepresentationType? and location.addressCode?)

VincentFeremans commented 1 year ago

Thank you very much for commenting on location.addressPosition and location.adressRepresentationType, @VPiersonSWDE.

location.addressPosition was added due to the fact that some water companies had attributes such as "Left", "Right" or "In front" in their data models which should refer to the position of a hydrant in relationship to a hydrant.signage or other object in the vicinity of a particular hydrant. Please let us know if this attribute should be removed from the model due to irrelevance or if you agree that it is included.

location.adressRepresentationType, this attribute would provide more information regarding the area in which a hydrant is located (e.g., a "commercial area", which might indicate that there will be a lot of civilians in the vicinity of the hydrants in this area). How it should be filled in is to be decided by all group members, in case it has been decided to keep this attribute. As this is merely a suggestion, please let us know if you believe this attribute should be removed from the model due to irrelevance.

Freddy-Theis-Zone-VHP commented 1 year ago

Bonsoir, Comme signalé à @VincentFeremans, je ne parle pas l'anglais et je voudrais clarifier quelques points car les correcteurs ne sont pas toujours au top. Pour qu'un dispatching puisse informer au mieux les intervenants il doit savoir faire la distinction entre une bouche et une borne. Bouche: Sous le sol = Une clé de bouche, un stand-pipe du bon diamètre (80/100mm - SWDE) et un ou des tuyaux pour se raccorder à une pompe. Borne: Au dessus du sol = Une petite clé pour libérer les raccords compatible avec la vanne d'ouverture/fermeture et un ou des tuyaux pour se raccorder à une pompe.

Sur ce point, vous pouvez déjà remarquer que mise à part le ou les tuyaux, l'intervenant ne doit pas prendre le même matériel pour se raccorder à une bouche ou à une borne.

location.addressPosition: Pour moi ce n'est pas utile.

Capture d’écran 2023-05-16 213342

Quand j'ai développé CAOPS pour les zones VHP et WAL, j'ai privilégié l'image à la lecture d'une géo donnée. Il est plus facile de transmettre des infos en les regardant qu'en les lisant.

En résumé, les données les plus importantes sont pour moi:

VincentFeremans commented 1 year ago

Dear @Freddy-Theis-Zone-VHP , thank you for your contribution.

We noted down the differences between above- and below ground hydrants and we refer you to this comment, where it's addressed https://github.com/belgif/thematic/issues/132#issuecomment-1573607387

In regards to the list of most important attributes for cartography that you provided, we would like to confirm with with you that they are already included in the model. Here is a brief summary;

In the Hydrant Entity https://github.com/belgif/thematic/issues/132, you can also already find the following:

VincentFeremans commented 1 year ago

Apart from the input we received from Vivaqua regarding https://github.com/belgif/thematic/issues/132, we also received attributes concerning location:

Attribute in our model Attribute in Vivaqua's model
location.municipalityName Commune
location.streetName Street
location.adressCode Zone
location.adressRepresentationType Private

Furthermore, Vivaqua has the following attributes, which are not in our model:

VincentFeremans commented 1 year ago

Through Zone VHP, we received the following insights:

We kindly ask the working group whether they agree with these insights.

VincentFeremans commented 1 year ago

_We have initiated the public review of the ICEG Hydrants model. We appreciate all the feedback we received within this conversation and want to notify that everything has been addressed in the model, which can be accessed via the following link: https://belgif.github.io/thematic/models/hydrants/index_en.html_

We advise you to review the model internally and welcome any final adjustment requests or suggestions you may have.

Kind regards, The ICEG Hydrants Team