search

belighted / bennett

Bennett is a continuous integration server aimed at Ruby on Rails applications and Git
MIT License
59 stars 15 forks source link

Cant clear a stuck build #47

Open fringley opened 12 years ago

fringley commented 12 years ago

One of my tasks seems to have fallen over, yet that command hasn't failed. I am unable to request a new build as it just gets queued and there is no way to stop the current build or delete it from the system.

Ive tried starting and stopping bennett, but that also doesn't seem to help.

(Im running the latest and greatest 4ba8b9daf732469ec21adc9a2a9dd6da6103bdec as I needed to be able to build a branch other than master )

joelcogen commented 12 years ago

Indeed, I already identified the problem, with actually two causes:

The first problem will be fixed when we switched to delayed_job to manage the queue, eliminating the need for a second database and making overall job management a lot easier. I'm working on this, but other issues on how the workers actually do their task must be resolved first (which is almost done).

For the second problem, I am sort of hoping that with the new workers and new queuing system, it will disappear. It may be wishful thinking, I guess we'll see soon :)

Anyway, the only fix for now is to manually remove the builds from the console, sorry.

Thanks a lot for your feedback!

fringley commented 12 years ago

Hey Joel,

Thanks very much for the update - it sounds like you have all of this in hand!

How would I go about removing the build from the console? There is no delete button for a build that hasn't "completed"?

Cheers, Chris

On 15 Oct 2012, at 13:10, Joel Cogen wrote:

Indeed, I already identified the problem, with actually two causes:

Bennett assumes that it always gets feedback from Resque, but this is not always the case (Resque might not even be running), which can cause weird statuses Sometimes builds finish but don't get their status updated, why I don't know... The first problem will be fixed when we switched to delayed_job to manage the queue, eliminating the need for a second database and making overall job management a lot easier. I'm working on this, but other issues on how the workers actually do their task must be resolved first (which is almost done).

For the second problem, I am sort of hoping that with the new workers and new queuing system, it will disappear. It may be wishful thinking, I guess we'll see soon :)

Anyway, the only fix for now is to manually remove the builds from the console, sorry.

Thanks a lot for your feedback!

— Reply to this email directly or view it on GitHub.

joelcogen commented 12 years ago

Find the build id from the URL, then do Build.find(ID).destroy. It's far from ideal but it will clean your results page. Or just leave them there and hopefully they will get replaced by successful builds...

fringley commented 11 years ago

Joel, that method works to clear the stuck builds - I forgot to thank you before. This is happening quite a lot now, especially with more and more projects within bennett. Whats the status of the improvements you have been working on that you mentioned before?

joelcogen commented 11 years ago

You're very welcome :)

You're right, I was waiting to finish all the other changes I started, but it is taking longer than expected, and I need to focus on the current version a little bit more. I'll update this week with the possibility to cancel builds from the interface, even if it is only a quick fix to a bigger problem. Hopefully the whole process will be fixed and better soon, but "soon" must be taken in the larger sense.

I'll keep you posted!

fringley commented 11 years ago

Great! Just a button in the UI to cancel would be great. Of course, we can test this quite easily for you if you need! The knock on issue we have also had is that pending builds will never start if they were queued up behind a stuck build after the dodgy one is deleted from the console!

Cheers!