search

belkiss / niftyplugins

Simple Perforce integration for Visual Studio 2017 to 2022
MIT License
24 stars 4 forks source link

Problems using Diff, Revision History, Time-lapse View, Revision Graph, Open Item since 3.0.5 #80

Open chaosmanAz opened 3 months ago

chaosmanAz commented 3 months ago

Hello!

I've recently updated from 3.0.4 to 3.0.5 and Diff, Revision History, Time-lapse View, Revision Graph, and Open Item have stopped working as they no longer try to use the correct server for me.

Previously these commands were using the default values (P4PORT, P4CLIENT, etc) and that was working great for me as I have setup my p4config files for each of my workspaces. https://github.com/belkiss/niftyplugins/commit/b8c19bea8e07271c4b56c418a6e6c504214423a4 changed the behavior so that it now fetches that information from what's generated by p4 info. This is problematic for me because p4 info returns either localhost:1999 for Server address or a server I can't directly reach as the Broker address which is what gets used for the Diff and friends commands.

I tried reverting the change at line 242 of https://github.com/belkiss/niftyplugins/commit/b8c19bea8e07271c4b56c418a6e6c504214423a4 and the Diff command worked again.

I saw that there's a history behind this change (https://github.com/belkiss/niftyplugins/issues/68) so I'm not sure what the best approach is as I would have thought of using p4 set to fetch P4PORT, etc, as was mentioned in https://github.com/belkiss/niftyplugins/issues/68.

Any ideas?

And thanks for keeping this extension alive!

belkiss commented 3 months ago

Heya!

Hum indeed since the code already had GetUserInfoStringFull I simply used it, but in case the data returned by p4 info is unusable locally it could create such errors.

I'll have a try at replacing this with data extracted from p4 set, and might leave an option in the setting to revert to previous behavior in case some users have issues with that approach.

Thanks for reporting and the kind words, and apologies for the breakage!

Cheers

chaosmanAz commented 3 months ago

I think adding an option to use p4 set or p4 info makes sense. If you come around to it I can give it a try for you :)

belkiss commented 3 months ago

Heya! I've pushed a commit that does what we discussed, you can try the updated extension by downloading it from the actions output (that's the vs2022 link): https://github.com/belkiss/niftyplugins/actions/runs/10021090082/artifacts/1721951706

Note that you might have to uninstall your current version of nifty, otherwise VS might consider it already installed.

I'll leave this open till I get your confirmation, and release a new version afterwards :)

Thanks!

chaosmanAz commented 3 months ago

Hello! Just gave it a quick try and works for me with P4Set! :D

Thanks a lot for the quick fix!