[macOS] Compiler should not be hardcoded, as gcc can also be used (and _should_ be used on some platforms)

bellard / quickjs

Public repository of the QuickJS Javascript Engine.

https://bellard.org/quickjs

Other

8.33k stars 867 forks source link

[macOS] Compiler should not be hardcoded, as gcc can also be used (and _should_ be used on some platforms) #320

Open barracuda156 opened 3 months ago

barracuda156 commented 3 months ago

Current Makefile forces Clang for macOS and FreeBSD, this is undesirable and in certain cases breaking. It is okay to fall back to Clang by default, but provided CC has not been set in the environment and build args.

chqrlie commented 3 months ago

I guess we could check for a CC environment variable. Note however that gcc on macOS is by default an alias for clang. The gcc toolchain can still be installed manually I suppose.

barracuda156 commented 3 months ago

@chqrlie Yes, gcc (real one) can be used on macOS. (On some legacy versions it is the only working compiler.)