search

bellebethcooper / cashew

macOS desktop app for GitHub issues
MIT License
26 stars 1 forks source link

Modernising #63

Open tonyarnold opened 5 years ago

tonyarnold commented 5 years ago

This PR is a work in progress - I'm looking at bringing everything up to the following levels:

It's going to be big, it's going to be messy and it's probably going to have to be broken down into smaller PRs.

zenspider commented 5 years ago

One problem I found with this (not made by you, but I'm testing against your code)... I use a case sensitive file system (legacy unix development reasons) and HotKey is trying to link against "Appkit", not "AppKit". The framework needs to be fixed AND the xcconfig file under Pods needs to be fixed (I thought I could find that via xcode build settings, but I couldn't).

tonyarnold commented 5 years ago

@zenspider I've created a PR on the upstream dependency (soffes/HotKey#10).

bellebethcooper commented 5 years ago

@tonyarnold Sorry for missing this! I wasn't getting any notifications from this repo and hadn't been working on Cashew so didn't see this PR. I haven't had a look at it yet—are you planning on adding more to it still?

tonyarnold commented 5 years ago

Not a problem at all @bellebethcooper!

I was planning on breaking it down quite a bit - I don't think this all needs to land in one go, I just wanted the work to be public. If you want to take it as-is or put it in a WIP branch then please, be my guest! 🌻

bellebethcooper commented 5 years ago

@tonyarnold Breaking it down sounds good to me. Hit me up if/when you need anything from me :)