search

bellecp / fast-p

MIT License
343 stars 26 forks source link

Need tester/feedback for homebrew formula #11

Closed bellecp closed 5 years ago

bellecp commented 6 years ago

I am considering a simpler installation for OSX users via a homebrew formula. Please report any issues/suggestions here -- all feedback welcome.

bellecp commented 6 years ago

Instructions to install with the formula are given at https://github.com/bellecp/fast-p#installation-on-osx-with-homebrew

Having no OSX machine available to test myself, I am interested in:

  1. Do the dependencies install correctly? (fzf, codeutils, findutils, etc)
  2. Does homebrew automatically make the binary fast-p available in your $PATH?
shamahJoe commented 6 years ago

Thanks a lot for making this available as a brew formula, it is a great tool!

Do the dependencies install correctly? (fzf, codeutils, findutils, etc)

The only dependency that was not automatically installed for me was ggrep, which it seems is not part of coreutils and is used by the bash p() function. There is a brew formula called grep that I manually installed to remedy this.

Does homebrew automatically make the binary fast-p available in your $PATH?

Yes it does.

bellecp commented 6 years ago

Thanks a lot or the feedback! I added the grep dependency.

soraros commented 5 years ago

Could you break the formula into two?

  1. fast-pdf-finder: has dependencies on (a newly introduced) fast-p, codeutils, findutils, etc.
  2. fast-p: with dependencies only poppler and pkg-config.

So that, if we want to use fd for the ag -U -g ".pdf$" part, we won't have ag automatically installed.

bellecp commented 5 years ago

@soraros : is an un extra possibly unused dependency such as ag an issue?

The current formula is built automatically with goreleaser, nothing is modified by hand. Two formulae and the loss of the automatic built would add complexity and make it harder to maintain.

soraros commented 5 years ago

@bellecp Oh, I meant fast-pdf-finder as a wrapper around the fast-p, with brew install fast-p behaving like download the prebuilt package from the release page, because building fast-p itself shouldn't need grep etc, right? Maybe I'm just making some false assumptions. The formula works fine and unused dependency is not a big problem, so big thank you anyway!

bellecp commented 5 years ago

Thanks for the pull request on the other repo. As explained there, your modification would be overwritten by the automatic build of the formula.

I prefer to keep all dependencies as it is now, so that all the tools needed for default bashrc code are installed. This is a trade-off, but I think the cost of extra dependencies is minor compared to the possible confusion where one installs the formula without recommended dependencies and the default formula fails to work.

askielboe commented 5 years ago

I just discovered this repository when looking for a way to search my 3000+ pdf files using fzf.

I followed the Homebrew install instructions in the README.md, added p () to my .zshrc and was up and running in less than 1 minute. No issues whatsoever! 🎉

I must say I'm really impressed with the performance and usability. Thanks a lot for making and sharing this!

bellecp commented 5 years ago

The formula seems to be working so far, closing this. Please comment/reopen or create a new issue if you encounter issues with OSX.