belligerentbeagle / pe

0 stars 0 forks source link

Add command provided is wrong #2

Open belligerentbeagle opened 4 months ago

belligerentbeagle commented 4 months ago

Context

Add command provided is wrong in the user guide: add n/James Ho p/22224444 e/jamesho@example.com a/123, Clementi Rd, 1234665 r/Treasurer r/Member c/CCA Cycling d/Manages money

It seems like the phone number needs to start with "8" or "9" instead of the "2" in the given example.

Screenshots

Screenshot 2024-04-19 at 4.21.43 PM.png

Why this severity:

As a new user using CCA Manager, it is likely that he would try out the commands provided in the user guide to understand how your app works. However, with the starting command being wrong, it hurts the user experience greatly.

soc-pe-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number restriction is restrictive for international users.

Description: According to the user guide, the value proposition is that "CCA Manager is a contact manager designed to simplify the management of CCAs and enhance your administrative efficiency, regardless of whether you're overseeing a sports team, academic club, any other extracurricular activity, or simply a CCA participant," where it does not specify that this produce is specifically for the schools in Singapore, nor it is stated in the UG/DG as a restriction. As an international student from South Korea, I want to manage the CCA and members with this product but it disallows adding other valid international phone numbers as an input. Since this could hinder the international users / users with different nationality from using this product without stated in the value proposition or restriction in the UG, I classified this as a feature flaw.

Stepts to reproduce: add n/John Doe p/01067136414 e/johnd@example.com a/6 Sin Ming #01-01 (phone number is valid South Korea's phone number (it is my phone number))

Expected: New person added (with the details on this person)

Actual: Phone numbers should only contain numbers, and it should be 8 digits long according to Singapore mobile number format which starts with 8 or 9.

Screenshot 2024-04-19 at 4.35.49 PM.png


[original: nus-cs2103-AY2324S2/pe-interim#1473] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did not emphasize that phone numbers have to be Singaporean phone number that starts with either 8 or 9 in our UG

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: My bug I reported isn't talking about the fact that international numbers should also be accepted, like what the duplicate bug raised. I accepted that the product is made for targeting schools in Singapore. So my complaint is that the example given in the user guide meant for users is not functional. Therefore not a feature flaw, it is a documentation issue.


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** (same as above) My bug I reported isn't talking about the fact that international numbers should also be accepted, like what the duplicate bug raised. I accepted that the product is made for targeting schools in Singapore. So my complaint is that the example given in the user guide meant for users is not functional. Therefore not a feature flaw, it is a documentation issue.