bellingcat / auto-archiver

Automatically archive links to videos, images, and social media content from Google Sheets (and more).
https://pypi.org/project/auto-archiver/
MIT License
581 stars 61 forks source link

Reload firefox driver on every spreadsheet row #31

Closed djhmateer closed 2 years ago

djhmateer commented 2 years ago

I suggest this PR as I has issues with idempotency between requests ie cookies were being remembered. Whilst this could be a feature, it was very hard to test, so even though it takes more CPU to load and unload the driver, it has made testing much easier for me.

A side effect I've noticed is that memory usage on production after 1000's of URL's archived is much less. I happily sit in 4GB of RAM now for my 1000's of URLs, and before it was maxing out 8GB. Some sort of memory leak.