Closed zameji closed 3 months ago
This also addresses #3 (via enabled / disabled paging) and implements #4.
Also migrated to Vue3 (as Vue2 is EoL for a while now). Did also major changes to the UI:
Backend changes
There are still some TODOs open:
@loganwilliams Some further UX improvements seem possible to me, but would require knowing more about how it's used - e.g. do people use the small previews more than the main map?
Thanks for this @zameji, really appreciate your work here. It will take me some time to review it, and I might ask you to break the PR into smaller feature specific chunks. I'll be in touch soon.
Best, Logan
Sure, take your time. Breaking it up is going to be somewhat problematic though, esp. in the frontend, since the migration to Vue3 brought with it a lot of necessary changes. In the backend, the individual commits should be smaller and easier to review by itself. If you have any questions/doubts about the design decisions, let me know - I'm open to trying different approaches.
Thanks @zameji, I understand that it might be hard to break up changes. As a first pass, to separate PR concerns, could you make one PR for front-end changes and one PR for back-end changes?
Sure @loganwilliams I'll look into that tonight / tomorrow night. The current frontend can't work with the new backend without a small change, though, because the interface changed. I'll include that change in the backend PR.
Closing this PR as:
This escalated a bit, main changes: