Comment threads can's be banned without trace

[GoogleCodeExporter]

Currently, if you ban a thread of comments (say, 3 comments, each replying to 
the previous one other, A, B and C), the result, as seen by a logged-off user, 
is two "Comment deleted" entries (placeholders corresponding to A and B, I 
assume). This doesn't allow banning threads without a trace. (In contrast, when 
a single comment is banned, it disappears completely.)

Original issue reported on code.google.com by robot...@gmail.com on 26 Nov 2011 at 5:41

[GoogleCodeExporter]

I changed this to work the way one would expect, hiding deleted comments unless 
they have visible descendants.  https://github.com/tricycle/lesswrong/pull/12

Original comment by mquan...@gmail.com on 12 Dec 2011 at 12:26

[GoogleCodeExporter]

Was it only for new comments? The following thread still has this problem:
  http://lesswrong.com/r/discussion/lw/8l5/facingthesingularitycom_discussion_page/5bpg

Original comment by robot...@gmail.com on 16 Dec 2011 at 12:03

[GoogleCodeExporter]

(Oh, I guess it's not in production yet.)

Original comment by robot...@gmail.com on 16 Dec 2011 at 12:04

[GoogleCodeExporter]

It was deployed briefly, but there was an issue with the code that meant I had 
to revert it.

Original comment by DRPow...@gmail.com on 16 Dec 2011 at 12:38

[GoogleCodeExporter]

Dave, did the issue get resolved and the code redeployed?

Original comment by wjmo...@gmail.com on 22 Apr 2012 at 11:16

• Changed state: Started

[GoogleCodeExporter]

Original comment by Matthew.Fallshaw on 3 Aug 2012 at 6:05

[GoogleCodeExporter]

The issue with the original code was pointed out by Dave:

https://github.com/tricycle/lesswrong/commit/b37a2157f6fe8d7bca0031696365ca536ec
e7f57

This problem needs to be addressed to finish this task.

Original comment by wjmo...@gmail.com on 15 Aug 2012 at 4:17

[GoogleCodeExporter]

Original comment by wjmo...@gmail.com on 15 Aug 2012 at 4:19

• Changed state: Accepted