bellroy / lesswrong

Less Wrong platform
http://lesswrong.org/
Other
45 stars 23 forks source link

Non-logged in users should use default visibility settings #555

Closed vaniver closed 8 years ago

vaniver commented 8 years ago

As discussed in lesswrong.com/r/discussion/lw/n9b/upcoming_lw_changes/d3qc , a user who is not logged in should not see heavily downvoted posts or links in the posts view, and heavily downvoted comments should be collapsed by default.

xrpd commented 8 years ago

There is an ".ini" file global setting (hide_comment_threshold) that currently overrides a user's hide comment preference (pref_min_comment_score). For example, if the global setting is "-4", but the user's preference is "-5", the comment will be hidden/collapsed if the comment score is -4 or less (I have confirmed this behavior in testing). It seems me that the user's preference should be the governing score, but let me know your thoughts.

The global setting also applies to anonymous readers - e.g., comments with score -4 are hidden/collapsed for anonymous readers. There is no equivalent global setting for links/posts, so they appear regardless of score.

My thought was to introduce two new global parameters (default_min_link_score, default_min_comment_score) and use these as the default parameters for users (the defaults for pref_min_link_score and pref_min_comment_score are currently both hard coded at -2), and as the working parameters for anonymous readers.

This provides a consistent experience, but seems to obviate the need for the currently existing "hide_comment_threshold" setting. Is it okay to delete the "hide_comment_threshold" setting, or should this remain as an independent setting that overrides user preferences?

xrpd commented 8 years ago

Patch #559 is intended to resolve this issue. I implemented as discussed in my previous comment. I didn't delete 'hide_comment_threshold', but its value will no longer have an effect on system functionality.

cdaloisio commented 8 years ago

Merged #559