search

bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

No POST params logged #104

Open kylecrum opened 10 years ago

kylecrum commented 10 years ago

As far as I can tell, it appears that POST params don't end up in the logging.

shaqq commented 10 years ago

POST params get kind of big, so that's most likely the biggest blocker.

Would we consider logging the keys of the params though? Or, if we'd like, we could do some smart truncation of the values.

jdoconnor commented 10 years ago

would logging the params in DEBUG make sense vs INFO?

On Wed, Oct 29, 2014 at 11:31 AM, Shaker Islam notifications@github.com wrote:

POST params get kind of big, so that's most likely the biggest blocker.

Would we consider logging the keys of the params though? Or, if we'd like, we could do some smart truncation of the values.

— Reply to this email directly or view it on GitHub https://github.com/bellycard/napa/issues/104#issuecomment-60956822.

kylecrum commented 10 years ago

Well, how do you guys debug POST requests in prod? Since most of my log viewing comes at the service of a log aggregation service and searching via that, I personally don't see what's so bad about logging POST params.