search

bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

WIP: update grape, ruby, roar gems #178

Closed jdoconnor closed 9 years ago

jdoconnor commented 9 years ago

fails tests related to acts_as_fu. Not sure why. any ideas?

shaqq commented 9 years ago

Should the upgrades to grape, ruby, roar, and activerecord be separate PR's?

That way we can version bump and such in a more responsible fashion. And, we can debug this spec failure easier :partly_sunny:

jdoconnor commented 9 years ago

Only if you want to have different versions. The author (this guy) should do it separately to figure out why it is failing.

shaqq commented 9 years ago

All of those are potentially breaking changes. I personally prefer version bumps in that case.

jdoconnor commented 9 years ago

the issue is activerecord's bump. I agree that they're all breaking changes for applications, but this would likely be a major revision bump, as it is bumping roar a major version

jdoconnor commented 9 years ago

the failing tests are in sortable_api. is there a reason why that isn't part of the napa_pagination gem? It seems to fit there better

umtrey commented 9 years ago

I'm not keen on moving that now.