search

bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

Removing dependence on git in gemspec #236

Closed ochagata closed 8 years ago

ochagata commented 8 years ago

This is a PR to fix #235

darbyfrey commented 8 years ago

This is the default gemspec configuration that Bundler creates. What benefits do you see from removing the git dependency?

ochagata commented 8 years ago

@darbyfrey It makes the assumption that everyone uses git. Bundler basically enforces it because they use it in their .gemspec

darbyfrey commented 8 years ago

I see. Is that a poor assumption to make? Are people using something other than git these days? That's a real question - I'm curious if I'm out of the loop.

ochagata commented 8 years ago

While git is the industry standard, people still use subversion and perforce. I just say make it as agnostic to the user's configuration as possible.

ochagata commented 8 years ago

Also this change was merged in with #240

darbyfrey commented 8 years ago

Yea, that makes sense. :+1: