Chore/setup rubocop for travis

bellycard / napa

A simple framework for building APIs with Grape

Other

329 stars 72 forks source link

Chore/setup rubocop for travis #240

Closed ochagata closed 8 years ago

ochagata commented 8 years ago

Fixed most style violations without making any tests start failing. Also, configured rakefile and travis.yml so that it will run rubocop and rspec on every commit.

ochagata commented 8 years ago

@darbyfrey It's green

darbyfrey commented 8 years ago

This looks great! Thanks for the contributions @ochagata!

@bellycard/platform please review these changes and let me know if you see any issues here.

+1 from me.

ashtonthomas commented 8 years ago

LGTM

darbyfrey commented 8 years ago

@ochagata, I'm going to merge this in a do a quick PR for that URL change.