Closed darbyfrey closed 8 years ago
Sounds good. I would still love to see the CI running the rubocop check though. @darbyfrey
:+1: for CircleCI (once passing), though you might need to find a way to tell it not to run rake db:create
(thinks its a rails app). I think you can do that using override
as discussed here: http://blog.joshsoftware.com/2013/12/18/overriding-circleci-settings-to-load-data-from-seed-and-rake-tasks/
@danielmackey build is green now
@ochagata want to update your PR to run rubocop once I merge this in?
If I can get a +1 I'll merge this one in right away
+1 from me.
@darbyfrey Yeah, I'll need to add an exclude for vendor. It included it and started running rubocop for all gems. I'll make the commit tomorrow
@darbyfrey Might need to change the config on either github or travis to make the builds stop, since the last commit had a failed build due to a missing .travis.yml
@ochagata it's just to put us in the mood for Christmas :christmas_tree:
;-)
@ashtonthomas :snowman:
@bellycard/platform
@ochagata We use CircleCI for everything else at Belly, but we haven't moved Napa over yet - now seems like a good time.