bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

logged hashes converted to key/value strings #260

Closed leeacto closed 8 years ago

leeacto commented 8 years ago

@bellycard/platform

Trello

When a hash is passed to a log line (non-request), it's in an unparseable format: <Hash> {:foo=>"bar"}

This extra work resets the data as foo=bar. It's an overwrite of this logging gem method.

I tested this in CampaignService locally and got the correct logs.

darbyfrey commented 8 years ago

Looks like the build failed on some rubocop checks

leeacto commented 8 years ago

bump

darbyfrey commented 8 years ago

LGTM +1

Let's push this to one service and verify that everything is flowing into Loggly as expected.