search

bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

monkey patch logger method #261

Closed leeacto closed 8 years ago

leeacto commented 8 years ago

@bellycard/platform

While the hash conversion worked in campaign service, it didn't work in user facts. Ashton thinks it was because another method eventually came along and overwrote the method. This monkey patch seems to work, as I tested it locally in user-facts (which previously didn't work)

ashtonthomas commented 8 years ago

I like this approach as it requires the least amount of changes. I think this is a case where monkey patching can be helpful. I also don't mind the directory format of /logger/logging/logger.rb as it is probably the only way to get this organized and still not conflict with anything.

+1 from me, maybe @darbyfrey has comments?