search

bellycard / napa

A simple framework for building APIs with Grape
Other
329 stars 72 forks source link

remove unicorn as gem dependency #81

Closed voxtex closed 10 years ago

voxtex commented 10 years ago

I'm not sure if there is a specific reason this is included as a dependency of the gem, but it seems unnecessary and breaks compatibility with jRuby. It'd be nice to remove it and not force it upon users of the framework.

darbyfrey commented 10 years ago

We were just talking about this the other day. We have some dependencies in here that are really part of the generator and not the gem itself. Unicorn is one of them.

Thanks for the PR! I'll merge this in. Are you using Napa with some jRuby apps?

darbyfrey commented 10 years ago

Actually, it looks like your fork is a little out of date, so it won't merge. Can you update so it can merge cleanly?

voxtex commented 10 years ago

Ah, sorry. I actually had this change pending for a while. Recently I also noticed you started using named params in grape_helpers.rb and jRuby is stuck on 1.9.3 for now. Other than that I find napa works great and I really appreciate the work you guys do.