search

beloglazov / vim-online-thesaurus

A Vim plugin for looking up words in an online thesaurus
Apache License 2.0
247 stars 21 forks source link

Add support for multiple definitions #15

Closed annagrram closed 9 years ago

annagrram commented 9 years ago

11

beloglazov commented 9 years ago

Thanks for this PR! However, I hesitate merging it in as I'm not familiar with Perl and maintaining this new code would be hard for me. Do you think it would be possible to implement this in awk/sed?

annagrram commented 9 years ago

That's understandable. I'm not really familliar with awk/sed. I use them just for small and trivial work. I guess it can be done with them. I can take a look a bit more at awk/sed and try to implement it that way, though it'll take me some time.

annagrram commented 9 years ago

Ok. I split the result transformation to two parts: Shell part and Vim part. I hope it's easier to maintain :)

beloglazov commented 9 years ago

Awesome, that was quick, thanks! :)

annagrram commented 9 years ago

Well, That's embarrassing. When I tested it, it seemed to do the right thing, so I haven't noticed the missing backslashes. I also usually use single quotes which doesn't need escaping. Sorry for that.

beloglazov commented 9 years ago

No worries, I've fixed it. Does the current version work well for you?

annagrram commented 9 years ago

Sure :)

beloglazov commented 9 years ago

:+1: I've added a list of contributors to the readme.