search

beloglazov / vim-online-thesaurus

A Vim plugin for looking up words in an online thesaurus
Apache License 2.0
247 stars 21 forks source link

Fix shell compatibility by using basic sh capabilities #23

Closed annagrram closed 9 years ago

annagrram commented 9 years ago

@Shurakai makes a good point in #22 that the variable substitution introduced lately isn't working on not bash-compatible shells. But, I don't really agree with the fix of changing sh to bash, because bash isn't available on every system by default (e.g. FreeBSD, OpenBSD, and maybe the rest of the BSDs).

This PR fixes the substitution by using sh capabilities only, and fixes another bug I've found when using vim with tcsh.

Checked on:

annagrram commented 9 years ago

You found a problem and made a fix that works (as long as you have bash installed). That's great. Thanks!

beloglazov commented 9 years ago

@av3r4ge thanks for the fix! I've tested it on Mac OS as well, it works fine.

annagrram commented 9 years ago

My pleasure. Only thing remaining is for @Shurakai to test it with dash and give his sign of approval :smiley: