search

beloglazov / vim-online-thesaurus

A Vim plugin for looking up words in an online thesaurus
Apache License 2.0
247 stars 21 forks source link

fix issue #34 #35

Closed Ron89 closed 8 years ago

Ron89 commented 8 years ago

Issue #34, happening since the last few days, was possibly caused by the redesign of the web page. The fix I wrote adjusted the value accordingly.

Ron89 commented 8 years ago

The request mainly deal with 2 things:

  1. Fix the issue raised by #34 .
  2. Replace the synonym separator from " " to ", ". So that multiple-word synonyms will no longer be confusing. Also, synonyms of different definitions are separated by end-of-line symbol.
    • the fix is intended to work on linux machine. On Windows machine, line 54 in plugin/online-thesaurus.vim should probably be changed(I'm not sure how exactly, I'm not a Windows user.).
beloglazov commented 8 years ago

Thanks for looking into this! I've fixed the issue slightly differently in 7aa259ac650bfd6639fb5078e364c0aef4bce8fa. Your fix didn't take into account the ordering based on relevance (sorting by relevant-\d). In the end, I basically only fixed the output based on the new layout: https://github.com/beloglazov/vim-online-thesaurus/commit/7aa259ac650bfd6639fb5078e364c0aef4bce8fa#diff-cb8657521b3556778eb0833f7e4467edR44