Added virtual destructor to IPrecedence base class

beltoforion / muparserx

A C++ Library for Parsing Expressions with Strings, Complex Numbers, Vectors, Matrices and more.

http://beltoforion.de/en/muparserx

BSD 2-Clause "Simplified" License

135 stars 60 forks source link

Closed guruofquality closed 6 years ago

guruofquality commented 7 years ago

This fixes a warning when building with -Wnon-virtual-dtor Since IPrecedence is an interface class with virtual methods

martinrotter commented 7 years ago

Yes, making destructors virtual is good idiom, which ensures that the actual objects are destroyed with correct destructors.

martinrotter commented 7 years ago

Maybe @beltoforion wants to comment this. If not, I can merge tomorrow.