search

beltransen / velo2cam_gazebo

Repository including Gazebo models, plugins and worlds to test calibration algorithms for Lidar-camera setups.
http://wiki.ros.org/velo2cam_gazebo
GNU General Public License v2.0
143 stars 42 forks source link

Remove velodyne_gazebo_plugin #2

Closed kmhallen closed 9 months ago

kmhallen commented 7 years ago

Would you consider removing the velodyne_gazebo_plugin package that was copied from DataspeedInc/velodyne_simulator now that issue vertical-laser-beams-appearing-higher has been addressed? I believe that is the only change you've made here.

I am only trying to reduce code duplication. You are completely within the BSD license to copy and change the code.

If there are any other changes you would like, let me know or raise an issue on the main repo.

By the way, I found out about this repository from a development build failure email.

beltransen commented 7 years ago

Hi kmhallen, Good to know the issue is already solved! We will check if there are any other changes and in case there aren't, we will proceed to the removal of the plugin in our repo. Btw, sorry about the dev build email you received =) , it was the first time we were submitting a package to ROS wiki and we forgot to change the package.xml of the plugin.

kmhallen commented 7 years ago

Awesome! Sounds good to me.