search

belugalearning / belugapad

0 stars 0 forks source link

Fraction with a number in front of it should be plural #1424

Closed sarahkk closed 11 years ago

sarahkk commented 11 years ago

ie. Show that there are twelve 1/4 in 3 should be read out as: Show that there are twelve one quarters in 3 but is read out as singular: Show that there are twelve one quarter in 3.

I'm pretty sure this plural fractions thing was put in, but this occurs in most the fraction questions in this pipeline

fractions and division/ use an image to divide a whole number by a unit fraction

garethjenkins commented 11 years ago

Sarah -- the plurals are only applied where the fraction itself knows it should be read like that. They don't do anything smart with what came before them in the sentence.

However... so you can force these things to pluralise when spoken, I've added a setting on b:on, pluraliseSpokenFraction -- if you set that to yes it'll always read out as plural denominator.

I realise that's not ideal -- i.e. you need to change the content, but it's far less risky than trying to intelligently assess the previous word or number.

crebello commented 11 years ago

TTS says for example "twelve one quarters" as opposed to "twelve quarters". All the examples I've changed have had 1 as the numerator, so should this behave like that?

garethjenkins commented 11 years ago

Difficult to determine where this should change -- recommend we leave as is.

Problem cases example would be "Show that there are 4 1/8 in 1/2" -- e.g. it should not turn this into "four eighths", as it's ambiguous. It's made worse if there are extra words in there "4 times 1/8" for example.

Also -- it's technically not wrong, just not brilliant.

Scott -- you happy for it to be closed?

garethjenkins commented 11 years ago

Sorry -- Scott, my last comment is in relation to Claire's last comment... the issue itself is resolved.

crebello commented 11 years ago

Ok, then I think all examples have been found. Will keep an eye out for any more that need changing.