search

belyalov / stm32-hal-libraries

Useful libraries for STM32 HAL
MIT License
85 stars 17 forks source link

Remove checksum byte from temp and hum measurement #2

Closed guilyx closed 5 years ago

belyalov commented 5 years ago

Looks good, to move forward please fix unittest test/test_si7021.cpp as well:

-  I2C_queue_receive_data(string("\x66\x9c\x00", 3));
-  I2C_queue_receive_data(string("\x0f\xff\x00", 3));
-  I2C_queue_receive_data(string("\x66\x9c\x00", 3));
+  I2C_queue_receive_data(string("\x66\x9c", 2));
+  I2C_queue_receive_data(string("\x0f\xff", 2));
+  I2C_queue_receive_data(string("\x66\x9c", 2));

-  I2C_queue_receive_data(string("\x6c\xb6\x00", 3));
+  I2C_queue_receive_data(string("\x6c\xb6", 2));
guilyx commented 5 years ago

Done ! :+1:

belyalov commented 5 years ago

Merged, thanks!