search

belyalov / stm32-hal-libraries

Useful libraries for STM32 HAL
MIT License
87 stars 18 forks source link

Set signal_bandwidth error #8

Closed aidan-fransen closed 2 years ago

aidan-fransen commented 2 years ago

Thanks for making this library available, saved me a lot of time.

However, when using this library I did notice there was a mistake in the lora_set_signal_bandwidth function.

The new bandwidth value is OR'd with the old value instead of replacing it. You can see the line I replaced it with below, it seems to work well.

image

belyalov commented 2 years ago

Hi @aidan-fransen

Thanks for noting!

Please feel free to make PR to fix it, I'd really appreciated!