search

belzaru17 / WorkshopOptimizerPlugin

FFXIV Island Sanctuary Workshop Optimizer Plugin
MIT License
8 stars 3 forks source link

Check if items level requirement is met. #14

Closed RuriRyan closed 10 months ago

RuriRyan commented 10 months ago

Very simple implementation, totally not stolen from https://github.com/NotNite/ReSanctuary.

I don't have everything unlocked yet and am missing a lot of materials. So I can't properly test it, but at least it shows me more reasonable combinations.

Fixes: #13

RuriRyan commented 10 months ago

The main problem with being low level is that you can't just go out and gather more, because some gatherables may still be locked. But I understand that when you have maxed out everything you just want to gather what you actually need.

For me the whole thing takes 2.5 seconds, which is fast enough I would say.

belzaru17 commented 10 months ago

I'm taking a slighly different approach to tackle your problem and another open FR to exlude only rare items. I'll have an update ~soon.

Thanks!

RuriRyan commented 10 months ago

Just pushed another update which should take almost everything into account. It not only checks the inventory, but also checks if a missing material is gatherable and if it is unlocked (even if the required tool is crafted). Also added a little check if the Item to be crafted is even available at the current level.

belzaru17 commented 10 months ago

Hey! I just pushed the version I was working on (that also checks for rare vs common materials). I do like the idea of checking for unlocked items. Things you can merge it?

belzaru17 commented 10 months ago

BTW; thanks for your help!

RuriRyan commented 10 months ago

I rebased my changes on the current main. I'm not 100% sure about this line: https://github.com/belzaru17/WorkshopOptimizerPlugin/pull/14/files#diff-5aa0f579e08557690b322e3fa4f1ff19b93705a84c4b2af118997274eac39b9fR195 As I can't test it right now, because of the maintenance.