search

bem-sdk-archive / bem-decl

:capital_abcd: Manage declaration of BEM entities. DEPRECATED →
https://github.com/bem/bem-sdk/tree/master/packages/decl
Other
11 stars 3 forks source link

[wip] Add convert for v1 format #70

Closed skad0 closed 7 years ago

skad0 commented 7 years ago

@blond @zxqfox for #78

skad0 commented 7 years ago

up, review needed @zxqfox @tadatuta @blond

skad0 commented 7 years ago

up /cc @zxqfox @tadatuta @blond

skad0 commented 7 years ago

up @zxqfox @blond @tadatuta @blond @blond @blond ^_^

tadatuta commented 7 years ago
  1. нужно отребейзить
  2. нужно исправить мессадж второго коммита (convertation -> conversion)
skad0 commented 7 years ago

🆙 @blond, по поводу тестов, не совсем понял какие кейсы еще не покрыты

qfox commented 7 years ago

@skad0 Tests were not passed. Check it please?

qfox commented 7 years ago

@skad0 Heya! Would be nice to see this in master

skad0 commented 7 years ago

@zxqfox will be happy if you can give me some advices tomorrow to complete this

skad0 commented 7 years ago

There is a try to create universal transformer based on which all other formatter can work.

skad0 commented 7 years ago

https://github.com/bem-sdk/bem-decl/issues/92