bem / bem-bl

Base BEM library
http://bem.github.com/bem-bl/
198 stars 84 forks source link

b-page__css: Inconsistent behavior of ie-key for desktop and touch #512

Open narqo opened 10 years ago

narqo commented 10 years ago

For the same BEMJSON for b-page block we have different results

{ elem : 'css', url : '10-simple', ie : true }

For desktop:

<!--[if gt IE 9]><!--><link rel="stylesheet" href="_10-simple.css"/><!--<![endif]-->
<!--[if IE 6]><link rel="stylesheet" href="_10-simple.ie6.css"/><![endif]-->
<!--[if IE 7]><link rel="stylesheet" href="_10-simple.ie7.css"/><![endif]-->
<!--[if IE 8]><link rel="stylesheet" href="_10-simple.ie8.css"/><![endif]-->
<!--[if IE 9]><link rel="stylesheet" href="_10-simple.ie9.css"/><![endif]-->

For touch:

<!--[if gte IE 9]><link rel="stylesheet" href="_10-simple"/><![endif]-->

Note that we lost .css suffix on the touch level

tadatuta commented 10 years ago

@narqo should it be fixed in major release or i can add something like indexOf('.css') > 0 as fallback and release patch version?

narqo commented 10 years ago

I don't mind if this would be fixed in minor release. But since nobody cares, one could wait for a major release without hacks :)

tadatuta commented 10 years ago

@narqo If there's nobody who's affected let's postpone it till major release

deeonis commented 9 years ago

@tadatuta @narqo welcome to BEM-2125 :)