search

bem / bem-bl

Base BEM library
http://bem.github.com/bem-bl/
198 stars 84 forks source link

i-ua: Fix double i-ua mixin to b-page__body on touch level. #569

Closed alexbaumgertner closed 9 years ago

alexbaumgertner commented 9 years ago

It's not a bug. We figured out the issue: there isn't bem-bl's bug: we have mix.push({block: 'i-ua', mods: {interaction: 'yes'}) in our level and, I didn't know about it – in mixing bemhtml set classes i-ua_interaction_yes and i-ua as well.

tadatuta commented 9 years ago

@alexbaumgertner don't you think it's better just to remove js: true on 46 line?

alexbaumgertner commented 9 years ago

No, js: true on 46 line is about data-bem attrs in script tag and this commit is about i-ua double mixin. But I'll check our lib more properly, may be the problem is there, because in https://github.com/bem/bem-bl/tree/dev/blocks-common I didn't find any b-page bemhtml template.

alexbaumgertner commented 9 years ago

We figured out the issue: there isn't bem-bl's bug: we have mix.push({block: 'i-ua', mods: {interaction: 'yes'}) in our level and, I didn't know about it – in mixing bemhtml set classes i-ua_interaction_yes and i-ua as well.