bem / bem-components

Set of components for sites development
https://bem.info/libraries/classic/bem-components/6.0.0/
Other
333 stars 87 forks source link

popup.js: delMod('visible') broken #965

Closed aliosv closed 10 years ago

aliosv commented 10 years ago

https://github.com/bem/bem-components/blob/v2/common.blocks/popup/popup.js#L558 zIndexes is undefined by default PR #966 /cc @tadatuta, @veged

dfilatov commented 10 years ago

Could you provide sequence of your actions?

aliosv commented 10 years ago

https://github.com/aliosv/project-stub/tree/bem-components.965

dfilatov commented 10 years ago

?

aliosv commented 10 years ago

there is demonstration of bug, build it to see

dfilatov commented 10 years ago

I've cloned your repo, pointed browser to desktop.bundles/index/index.html and haven't seen anything about this bug.

aliosv commented 10 years ago

check browser console. image

dfilatov commented 10 years ago

I see nothing interesting in browser console.

dfilatov commented 10 years ago

Could you provide your actions step by step?

aliosv commented 10 years ago

git clone git@github.com:aliosv/project-stub.git -b bem-components.965 npm i bem server .../index.html

win 7, checked in latest ff, chrome, yabrowser

dfilatov commented 10 years ago

I've understood. You are trying to set visible : true modifier from bemjson. That case isn't supported right now at all, because only js can properly position popup. We should add notes about that in documentation.

aliosv commented 10 years ago

ok, thanks

innabelaya commented 10 years ago

добавила информацию в блок popup(в рамках #944), спасибо!