bem / bem-core

BEM Core Library
https://ru.bem.info/technologies/classic/i-bem/
Other
276 stars 95 forks source link

i-bem-dom: Rename _js_inited modifier to _inited #1068

Open narqo opened 9 years ago

narqo commented 9 years ago

_js_inited looks like an artifact of ancient age, when be didn't have boolean modifiers. Now, as we have them, it looks more natural to have _inited modifier, as we do have _disabled, _pressed Etc.

cc @dfilatov

belozer commented 6 years ago

@veged What you think?

veged commented 6 years ago

I think it's backward incompatible change without really strong needs

qfox commented 6 years ago

I think it's backward incompatible change without really strong needs

Almost the same as naming change ;-D Reading your answer as YES

belozer commented 6 years ago

@veged @zxqfox v5 in processing ;) Major. Maybe need include this rename?

veged commented 6 years ago

@zxqfox «backward incompatible change without really strong needs» means NO (and I'm sure you understand what I mean ;-))

qfox commented 6 years ago

@zxqfox «backward incompatible change without really strong needs» means NO (and I'm sure you understand what I mean ;-))

Holy crap! All my life I got you wrong ;-(